Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SlowOnDamage lessened + Moth buff #741

Conversation

OldDanceJacket
Copy link
Contributor

@OldDanceJacket OldDanceJacket commented Jan 31, 2024

The Changes Are:

SlowOnDamage values changed from
60dmg 0.7 -> 0.8
80dmg 0.5 -> 0.6

Moth Heat weakness lessened from
4.5 -> 4

Why / Balance

SlowOnDamage values are changed to the much older Nyano balance changes, this was one of the most well received balance changes, it is a simple change in speed but helps assist in making death spiral moments feel considerably better. Players have a number of sources to be slowed down by already, and this allows melee combat to be a bit more engaging.

~

Moth heat weakness used to be 2, for some reason it's cranked up to 4.5 of all things. Players would complain about the old 2 modifier, and with how damage is dealt with Heat currently this means there's some comical ways to take out Moth players. A 1.5 weakness is still plenty but should allow the on fire moth a little bit more wiggle room in having someone douse them if they catch fire. (Or when getting shot at by a laser gun...)

~

These changes are bundled together due to being both simple yml changes in the same folder, as well as also balance changes of a similar vein (improving the play experience of the players)

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

🆑 ODJ

  • tweak: Moth's now take less heat dmg.
  • tweak: You now move a little faster when hurt than previously

Signed-off-by: OldDanceJacket <[email protected]>
Signed-off-by: OldDanceJacket <[email protected]>
@OldDanceJacket
Copy link
Contributor Author

Wouldn't be a pr if there wasn't a test failure

@FluffiestFloof
Copy link
Contributor

FluffiestFloof commented Jan 31, 2024

I'm pretty sure that the default MobFlammable (aka anyone) is 3 Heat while on fire so wouldn't giving Moth 1.5 make them less flammable?

Copy link
Contributor

@DebugOk DebugOk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually making moths take less damage, as by default you already take 3 heat damage per fire stack.

# Used for mobs that can be set on fire
- type: entity
save: false
id: MobFlammable
abstract: true
components:
- type: Flammable
fireSpread: true
canResistFire: true
damage: #per second, scales with number of fire 'stacks'
types:
Heat: 3
- type: FireVisuals
sprite: Mobs/Effects/onfire.rsi
normalState: Generic_mob_burning

Additionally, the damage slowdown changes are lacking change markers

Copy link
Contributor

@DebugOk DebugOk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also fix your changelog entries

Resources/Prototypes/Entities/Mobs/Species/base.yml Outdated Show resolved Hide resolved
Resources/Prototypes/Entities/Mobs/Species/moth.yml Outdated Show resolved Hide resolved
@DebugOk DebugOk merged commit cf7fccf into DeltaV-Station:master Feb 1, 2024
10 checks passed
DeltaV-Bot pushed a commit that referenced this pull request Feb 1, 2024
@OldDanceJacket OldDanceJacket deleted the SlowOnDamage-Lessened-+-Moth-Buff branch February 2, 2024 03:36
ghost pushed a commit that referenced this pull request Aug 27, 2024
* Oni Horn Markings (#726)

# Description

---

Three new Oni horn markings,] two of which have three tone support.
There was a distinct lack of large horns, which I tried my hand at.

<details><summary><h1>Media</h1></summary>
<p>


![display](https://github.com/user-attachments/assets/cb0604e8-941c-48fd-8fb8-205893b87c5c)

</p>
</details>

---

# Changelog

<!--
You can add an author after the `:cl:` to change the name that appears
in the changelog (ex: `:cl: Death`)
Leaving it blank will default to your GitHub display name
This includes all available types for the changelog
-->

:cl:
- add: Added crowned, tall bull, and tall curved Oni horns.

* Oni Pointy Ears And Tusks (#727)

# Description

Adds eight pointy ears, two tusks, one feet marking (toes resembling
WarCraft trolls) and human nose markings to Onis. The pointed ears are a
big reference to tieflings (similar to Onis) who often have them.

Onis will now have pointy ears by default, but there is a marking to
disable ears.

5 human nose markings have all been made available to Onis, Harpies, and
Felinids. Onis and Felinids can now get chest scars, originally
humna-only. The tusk markings are originally from Frontier goblins.

The new pointy ears give players the power to make their Onis look like
**tieflings, orcs, elves, goblins**, and more fantasy races.

These markings can potentially be used in the future for other species
like psionic elves.

## Media

**Blood Elf** (Tall Ears)


![image](https://github.com/user-attachments/assets/257c8839-303c-45b2-b129-3f9183e47695)

<details><summary>See more</summary>

**Orc** (Upward Ears, Large Tusks)


![image](https://github.com/user-attachments/assets/46bac694-de88-4e04-a12b-7ff8a8111e7b)

**Night Elf** (Wide Ears)


![image](https://github.com/user-attachments/assets/18813660-cd2c-4d37-800d-bf84b1d7dee5)

**Night Elf** (Slanted Ears)


![image](https://github.com/user-attachments/assets/7f39457b-875d-4c46-a5fb-428a6a535fb1)

**Troll** (Large Ears, Small Tusks, Two-Toed Feet)


![image](https://github.com/user-attachments/assets/d9a0c52e-020d-4b55-bb7e-7a4afed61dcc)

**Character Setup**


![image](https://github.com/user-attachments/assets/35ba27d4-e6d1-4c52-bbc7-0f057df12fc8)


![image](https://github.com/user-attachments/assets/5d9e7690-7118-48b3-95b9-50ee784660e2)

</details>

## Changelog

:cl: Skubman
- add: Onis have received eight new pointy ear markings in the 'Head
(Side)' section that can help them resemble tieflings, orcs, elves,
goblins, trolls, and more.
- add: Onis get two new tusk markings in the 'Snout' section, and a
Two-Toed feet marking in the 'Legs' section.
- add: Felinids, Onis, and Harpies can now select Human nose markings
like the schnozz, blobby nose, and nubby nose.
- add: Felinids and Onis can now select the Chest Scar and Top Surgery
Scar markings.
- tweak: Default Onis now use the Double Curved horn and Upward Ears
markings.

* [S] Onis: Get A Boatload Of Troll Horns. (#741)

# Description

Adds **16** new horns to Onis, 10 of which are inspired by **Homestuck**
trolls. Most of the new horns have three-tone variants, and some also
have striped variants.

New horns and available variants:
- Antlers (Three Tone)
- Aries (Three Tone)
- Double Thick (Striped, Three Tone)
- Erebia (Ringed, Three Tone)
- Inclined (Three Tone)
- Makara (Striped, Three Tone)
- Nepeta (Three Tone)
- Pisces (Striped, Three Tone)
- Sagittarius
- Serket (Three Tone)
- Taurus (Striped, Three Tone)
- Tavris (Three Tone)
- Unicorn
- Vantas (Three Tone)
- Virgo (Three Tone)
- Wavy (Striped, Three Tone)
- Three Tone for the existing Double Curved horn
- Three Tone for the existing Double Curved Outwards horn

## Media

**Serket (Three Tone)**


![image](https://github.com/user-attachments/assets/69beabb3-01ea-49ac-9e9e-8d9351bf99df)

<details><summary>See more</summary>

**Makara (Striped)**


![image](https://github.com/user-attachments/assets/839707b7-c063-41f4-b59f-dc36f2126967)

**Aries (Three Tone)**


![image](https://github.com/user-attachments/assets/ba7a65da-06d0-4ddd-b0d0-afa9cff5ad03)


![image](https://github.com/user-attachments/assets/b4abcdd2-a11e-4d4f-be61-1970e78cf588)

**Antlers**


![image](https://github.com/user-attachments/assets/cfb47d5b-f985-4dbe-b86d-96c31472007f)

**Pisces (Striped)**


![image](https://github.com/user-attachments/assets/9426c51e-49fe-41d4-b049-ee8b1a159c57)

**Wavy**


![image](https://github.com/user-attachments/assets/c29420aa-4576-49ec-af08-0ff38aff7ea4)

**Taurus (Striped)**


![image](https://github.com/user-attachments/assets/9aa3084e-4acc-473e-b875-465b242d0551)

**Nepeta (Three Tone)**


![image](https://github.com/user-attachments/assets/639abc4a-0cf1-456a-b214-6520e39e992f)

**Sagittarius (Three Tone)**


![image](https://github.com/user-attachments/assets/2a4a7c6f-0678-462d-8de6-f8fe6c10aef3)

**Unicorn**


![image](https://github.com/user-attachments/assets/6783cbd4-2dcf-4204-bb03-3f3601e1c6f7)


![image](https://github.com/user-attachments/assets/c09f7ef3-a0e3-429f-be70-76db0232ad01)

</details>

## Changelog

:cl: Skubman
- add: 16 new horns for Onis have been added, with three-tone variants
and some striped variants! The new horns include the Serket, Nepeta,
Vantas, Makara, and more.
- add: The Oni horns Double Curved and Double Curved Outwards have
received three-tone variants.

* Respacing to EE

* I forgot human.yml, apparently, but we're fiiine.

---------

Co-authored-by: dootythefrooty <[email protected]>
Co-authored-by: Angelo Fallaria <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants